-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix async-inf broken link #59917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix async-inf broken link #59917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the orphan: true directive to the frontmatter of doc/source/serve/tutorials/asynchronous-inference/content/README.md. This is a standard and correct way to prevent Sphinx from issuing warnings about a document that is not included in any toctree, which is common for files that are included within other documents. The change is appropriate and helps ensure a clean documentation build. For better traceability, it would be beneficial to fill out the pull request description to provide context for the change.
Signed-off-by: harshit <[email protected]>
1b71a7d to
aef5a17
Compare
Signed-off-by: harshit <[email protected]>
dstrodtman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
- async-inf readme wasn't included in toctree, and was included in the exclude pattern list, fixed it. Signed-off-by: harshit <[email protected]> Signed-off-by: jasonwrwang <[email protected]>
- async-inf readme wasn't included in toctree, and was included in the exclude pattern list, fixed it. Signed-off-by: harshit <[email protected]>
…registry example (#60071) Noticed #59917 but it didn't fix it - Linking to notebook instead of README.md - Removing notebook from exclude_patterns The notebook should be the single source of truth since it’s what's tested and validated, so we should link to it rather than the README.md. The README.md is generated from the notebook (jupyter nbconvert) and exists only for display in the console when converting the example into an Anyscale template Also fixing the error 404 of the mlflow registry example by lin,ing to the proper doc --------- Signed-off-by: Aydin Abiar <[email protected]> Signed-off-by: Aydin Abiar <[email protected]> Co-authored-by: Aydin Abiar <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.